chore: upgrade ngrx #30255 #30256
Merged
chore: upgrade ngrx #30255 #30256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
requested review from
nicobytes,
zJaaal,
rjvelazco,
valentinogiardino,
KevinDavilaDotCMS and
hmoreras
hmoreras
approved these changes
Oct 4, 2024
valentinogiardino
approved these changes
Oct 11, 2024
oidacra
force-pushed
the
issue-30255-upgrade-ngrx
branch
from
3089c49
to
f4ae869
Compare
oidacra
force-pushed
the
issue-30255-upgrade-ngrx
branch
2 times, most recently
from
47ef119
to
4f89eb5
Compare
oidacra
force-pushed
the
issue-30255-upgrade-ngrx
branch
from
0bbb6ed
to
750b49f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request primarily focuses on refactoring imports across multiple files to improve code organization and maintainability. The most significant changes involve moving
tapResponsefrom@ngrx/component-storeto@ngrx/operatorsand reordering some imports for consistency.Refactoring imports:
core-web/apps/dotcdn/src/app/dotcdn.component.store.ts: MovedtapResponseto@ngrx/operators.core-web/apps/dotcms-ui/src/app/portlets/dot-pages/dot-pages-store/dot-pages.store.ts: MovedtapResponseto@ngrx/operators.core-web/apps/dotcms-ui/src/app/portlets/dot-templates/dot-template-create-edit/store/dot-template.store.ts: MovedtapResponseto@ngrx/operators.core-web/libs/block-editor/src/lib/extensions/ai-content-prompt/store/ai-content-prompt.store.ts: MovedtapResponseto@ngrx/operators.core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts: Reorganized imports and movedtapResponseto@ngrx/operators.Additional changes:
core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts: Added type annotation toinitialStateand updated computed property logic. [1] [2]core-web/libs/edit-content/src/lib/fields/dot-edit-content-file-field/store/file-field.store.ts: Added temporary protected state for unit tests.core-web/libs/portlets/edit-ema/portlet/src/lib/store/dot-uve.store.ts: Added temporary protected state for unit tests.Checklist
This PR fixes: #30255