Auto-create SSL server cert for ACME on separate instance #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkispawn has been updated to use the ACME's issuer to provide the cert chain and to automatically issue an SSL server cert for ACME on separate instance. The PKIDeployer.import_cert_chain() has been modified to retrieve the cert chain from the ACME issuer. The PKIDeployer.get_ca_signing_cert() has been modified to ignore UNKNOWN_ISSUER error. The PKIDeployer.issue_cert() has been modified to support optional install token, subject DN, and issuer credentials. The test for ACME on separate instance has been modified to automatically issue an SSL server cert. The original test with manual SSL server cert creation has been moved into a separate test.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkispawnhas been updated to use the ACME's issuer to provide the cert chain and to automatically issue an SSL server cert for ACME on separate instance.The
PKIDeployer.import_cert_chain()has been modified to retrieve the cert chain from the ACME issuer.The
PKIDeployer.get_ca_signing_cert()has been modified to ignoreUNKNOWN_ISSUERerror.The
PKIDeployer.issue_cert()has been modified to support optional install token, subject DN, and issuer credentials.The test for ACME on separate instance has been modified to automatically issue an SSL server cert.
The original test with manual SSL server cert creation has been moved into a separate test.