Update pki tps-config doc #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Link constructor has been modified not to set the type if it's not specified to match RESTEasy's Link constructor: https://github.com/resteasy/Resteasy/blob/3.0.26.Final/providers/resteasy-atom/src/main/java/org/jboss/resteasy/plugins/providers/atom/Link.java#L54-L58
The doc for pki tps-config has been updated to use JSON instead of XML file format.
|
@edewata this |
ckelleyRH
approved these changes
Jul 8, 2021
I filed these tickets for that issue: The code is quite low-level and complex, so I'm not sure who will be able to fix it properly, but it seems to be happening only when closing the connection, so we might be able to just add a code to ignore the NPE. |
|
@ckelleyRH Thanks! I'll merge both PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc for
pki tps-confighas been updated to use JSON instead of XML file format:https://github.com/edewata/pki/blob/json/docs/changes/v11.0.0/Switching-from-XML-to-JSON-REST-API.adoc
https://github.com/edewata/pki/blob/json/docs/user/tools/Using-PKI-TPS-Configuration-CLI.adoc
The
Linkconstructor has been modified not to set the type if it's not specified to match RESTEasy'sLinkconstructor:https://github.com/resteasy/Resteasy/blob/3.0.26.Final/providers/resteasy-atom/src/main/java/org/jboss/resteasy/plugins/providers/atom/Link.java#L54-L58
Note: This PR should be merged together with PR #3610.