Update test for CA with caDirPinUserCert profile

The test for CA with caDirPinUserCert profile has been updated
to perform enrollments using pki ca-cert-issue command and also
manually using XML and JSON messages.

https://github.com/dogtagpki/pki/wiki/Certificate-Enrollment-with-PIN-Authenticated-Profile

.github/workflows/ca-profile-caDirPinUserCert-test.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Install dependencies
         run: |
           sudo apt-get update
-          sudo apt-get -y install jq moreutils
+          sudo apt-get -y install jq libxml2-utils moreutils xmlstarlet
 
       - name: Clone repository
         uses: actions/checkout@v4
@@ -87,6 +87,15 @@ jobs:
           cn: Test User 2
           sn: User
           userPassword: Secret.123
+
+          dn: uid=testuser3,ou=people,dc=example,dc=com
+          objectClass: person
+          objectClass: organizationalPerson
+          objectClass: inetOrgPerson
+          uid: testuser3
+          cn: Test User 3
+          sn: User
+          userPassword: Secret.123
           EOF
 
       - name: Set up PKI container
@@ -200,7 +209,7 @@ jobs:
               --pkcs12-password Secret.123
           docker exec pki pki -n caadmin ca-user-show caadmin
 
-      - name: Check enrollment with pki ca-cert-request-submit
+      - name: Check enrollment using pki ca-cert-issue
         run: |
           PIN=$(sed -En 'N; s/^dn:uid=testuser1,.*\npin:(.*)$/\1/p; D' setpin.out)
           echo "PIN: $PIN"
@@ -212,30 +221,27 @@ jobs:
 
           echo "Secret.123" > password.txt
           echo "$PIN" > pin.txt
-          docker exec pki \
-              pki ca-cert-request-submit \
+
+          # issue cert
+          docker exec pki pki \
+              ca-cert-issue \
               --profile caDirPinUserCert \
               --username testuser1 \
               --password-file $SHARED/password.txt \
               --pin-file $SHARED/pin.txt \
               --csr-file $SHARED/testuser1.csr \
-              | tee output
-
-          CERT_ID=$(sed -n "s/^\s*Certificate ID:\s*\(\S*\)$/\1/p" output)
+              --output-file testuser1.crt
 
-          # retrieve cert
-          docker exec pki pki ca-cert-export $CERT_ID --output-file testuser1.crt
+          # import cert
           docker exec pki pki nss-cert-import testuser1 --cert testuser1.crt
-
-          # install cert
           docker exec pki pki nss-cert-show testuser1 | tee output
 
           # the cert should match the key (trust flags must be u,u,u)
           echo "u,u,u" > expected
           sed -n "s/^\s*Trust Flags:\s*\(\S*\)$/\1/p" output > actual
           diff expected actual
 
-      - name: Check enrollment with curl
+      - name: Check enrollment using XML
         run: |
           PIN=$(sed -En 'N; s/^dn:uid=testuser2,.*\npin:(.*)$/\1/p; D' setpin.out)
           echo "PIN: $PIN"
@@ -245,56 +251,156 @@ jobs:
               --subject "UID=testuser2" \
               --csr $SHARED/testuser2.csr
 
+          # retrieve request template
+          docker exec pki curl \
+              -k \
+              -s \
+              -H "Content-Type: application/xml" \
+              -H "Accept: application/xml" \
+              https://pki.example.com:8443/ca/rest/certrequests/profiles/caDirPinUserCert \
+              | xmllint --format - \
+              | tee testuser2-request.xml
+
+          # insert username
+          xmlstarlet edit --inplace \
+              -s "/CertEnrollmentRequest/Attributes" --type elem --name "Attribute" -v "testuser2" \
+              -i "/CertEnrollmentRequest/Attributes/Attribute[not(@name)]" -t attr -n "name" -v "uid" \
+              testuser2-request.xml
+
+          # insert password
+          xmlstarlet edit --inplace \
+              -s "/CertEnrollmentRequest/Attributes" --type elem --name "Attribute" -v "Secret.123" \
+              -i "/CertEnrollmentRequest/Attributes/Attribute[not(@name)]" -t attr -n "name" -v "pwd" \
+              testuser2-request.xml
+
+          # insert PIN
+          xmlstarlet edit --inplace \
+              -s "/CertEnrollmentRequest/Attributes" --type elem --name "Attribute" -v "$PIN" \
+              -i "/CertEnrollmentRequest/Attributes/Attribute[not(@name)]" -t attr -n "name" -v "pin" \
+              testuser2-request.xml
+
+          # insert request type
+          xmlstarlet edit --inplace \
+              -u "/CertEnrollmentRequest/Input/Attribute[@name='cert_request_type']/Value" \
+              -v "pkcs10" \
+              testuser2-request.xml
+
+          # insert CSR
+          xmlstarlet edit --inplace \
+              -u "/CertEnrollmentRequest/Input/Attribute[@name='cert_request']/Value" \
+              -v "$(cat testuser2.csr)" \
+              testuser2-request.xml
+
+          cat testuser2-request.xml
+
+          # submit request
+          docker exec pki curl \
+              -k \
+              -s \
+              -X POST \
+              -d @$SHARED/testuser2-request.xml \
+              -H "Content-Type: application/xml" \
+              -H "Accept: application/xml" \
+              https://pki.example.com:8443/ca/rest/certrequests \
+              | xmllint --format - \
+              | tee testuser2-response.xml
+          CERT_ID=$(xmlstarlet sel -t -v '/CertRequestInfos/CertRequestInfo/certID' testuser2-response.xml)
+
+          # retrieve cert
+          docker exec pki curl \
+              -k \
+              -s \
+              -H "Content-Type: application/xml" \
+              -H "Accept: application/xml" \
+              https://pki.example.com:8443/ca/rest/certs/$CERT_ID \
+              | xmllint --format - \
+              | tee testuser2-cert.xml
+
+          # The XML transformation in CertData.toXML() converts "\r"
+          # chars in the cert into "
" which need to be removed.
+          # TODO: Fix CertData.toXML() to avoid adding "
".
+          xmlstarlet sel -t -v '/CertData/Encoded' testuser2-cert.xml \
+              | sed 's/
$//' \
+              | tee testuser2.crt
+
+          # import cert
+          docker exec pki pki nss-cert-import testuser2 --cert $SHARED/testuser2.crt
+          docker exec pki pki nss-cert-show testuser2 | tee output
+
+          # the cert should match the key (trust flags must be u,u,u)
+          echo "u,u,u" > expected
+          sed -n "s/^\s*Trust Flags:\s*\(\S*\)$/\1/p" output > actual
+          diff expected actual
+
+      - name: Check enrollment using JSON
+        run: |
+          PIN=$(sed -En 'N; s/^dn:uid=testuser3,.*\npin:(.*)$/\1/p; D' setpin.out)
+          echo "PIN: $PIN"
+
+          # generate cert request
+          docker exec pki pki nss-cert-request \
+              --subject "UID=testuser3" \
+              --csr $SHARED/testuser3.csr
+
           # retrieve request template
           docker exec pki curl \
               -k \
               -s \
               -H "Content-Type: application/json" \
               -H "Accept: application/json" \
               https://pki.example.com:8443/ca/rest/certrequests/profiles/caDirPinUserCert \
-              | python -m json.tool > request.json
-
-          cat request.json
+              | python -m json.tool \
+              | tee testuser3-request.json
 
           # insert username
-          jq '.Attributes.Attribute[.Attributes.Attribute|length] |= . + { "name": "uid", "value": "testuser2" }' \
-              request.json | sponge request.json
+          jq '.Attributes.Attribute[.Attributes.Attribute|length] |= . + { "name": "uid", "value": "testuser3" }' \
+              testuser3-request.json | sponge testuser3-request.json
 
           # insert password
           jq '.Attributes.Attribute[.Attributes.Attribute|length] |= . + { "name": "pwd", "value": "Secret.123" }' \
-              request.json | sponge request.json
+              testuser3-request.json | sponge testuser3-request.json
 
           # insert PIN
           jq --arg PIN "$PIN" '.Attributes.Attribute[.Attributes.Attribute|length] |= . + { "name": "pin", "value": $PIN }' \
-              request.json | sponge request.json
+              testuser3-request.json | sponge testuser3-request.json
 
           # insert request type
           jq '( .Input[].Attribute[] | select(.name=="cert_request_type") ).Value |= "pkcs10"' \
-              request.json | sponge request.json
+              testuser3-request.json | sponge testuser3-request.json
 
           # insert CSR
           jq --rawfile cert_request testuser2.csr '( .Input[].Attribute[] | select(.name=="cert_request") ).Value |= $cert_request' \
-              request.json | sponge request.json
+              testuser3-request.json | sponge testuser3-request.json
 
-          cat request.json
+          cat testuser3-request.json
 
           # submit request
           docker exec pki curl \
               -k \
               -s \
               -X POST \
-              -d @$SHARED/request.json \
+              -d @$SHARED/testuser3-request.json \
               -H "Content-Type: application/json" \
               -H "Accept: application/json" \
-              https://pki.example.com:8443/ca/rest/certrequests | python -m json.tool | tee output
-          CERT_ID=$(jq -r '.entries[].certId' output)
+              https://pki.example.com:8443/ca/rest/certrequests \
+              | python -m json.tool \
+              | tee testuser3-response.json
+          CERT_ID=$(jq -j '.entries[].certId' testuser3-response.json)
 
           # retrieve cert
-          docker exec pki pki ca-cert-export $CERT_ID --output-file testuser2.crt
-          docker exec pki pki nss-cert-import testuser2 --cert testuser2.crt
-
-          # install cert
-          docker exec pki pki nss-cert-show testuser2 | tee output
+          docker exec pki curl \
+              -k \
+              -s \
+              -H "Content-Type: application/json" \
+              -H "Accept: application/json" \
+              https://pki.example.com:8443/ca/rest/certs/$CERT_ID \
+              | python -m json.tool \
+              | tee testuser3-cert.json
+          jq -j '.Encoded' testuser3-cert.json | tee testuser3.crt
+
+          # import cert
+          docker exec pki pki nss-cert-import testuser3 --cert $SHARED/testuser3.crt
+          docker exec pki pki nss-cert-show testuser3 | tee output
 
           # the cert should match the key (trust flags must be u,u,u)
           echo "u,u,u" > expected