-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using simpler oneliner for go vet #62
base: master
Are you sure you want to change the base?
Conversation
There have been a number of PRs opened to fix/improve the govet hook. My latest recommendation is here. If you want to run |
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
* chore: go vet is already called by golangci-lint See dnephin/pre-commit-golang#62 (comment) and https://golangci-lint.run/usage/linters/ * chore: bump precommit-golang * chore: run golangci-lint for modified files Enable the fast linter preset and only run it on newly-modified files, and fix problems as they arise, if the linter supports it * chore: fix line endings * chore: expllicitly set filepaths for gherkin files * chore: remove trail comma in arrays' last items * chore: add empty Go file to the root directory Golangci-lint is able to continue * chore: add Go license to empty file
The go vet check is failing in this PR (the logs are here). I'm not sure what's going on, but modern
go vet ./...
will run through all files in the repo. this is suboptimal, but it's not extremely slow in many cases. perhaps there should be two checks? just an idea, not sure if it's necessary