Update examples to use new JS backend syntax #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Javascript conventions have changed slightly with the GHC Javascript backend (from GHCJS). - See https://github.com/ghcjs/ghcjs-base/pull/135/files. - Update foreign imports to match these new conventions, so compiling with GHC Javascript backend works.
- Update canvas2d to work with new JS backend syntax.
|
Thanks for doing this, in order to ensure it works we'll need to update miso's nix scripts to use the new ghcjs. @stepcut has pointed out that |
|
Thanks for your work on the project! I'll do my best to help out with that process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreign imports. These need to be updated to the new GHC JS backend syntax in order to work with the new GHC JS backend.