Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix optiongroupserializer missing #344

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

bugfix optiongroupserializer missing #344

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9485176
bugfix optiongroupserializer missing
svandeneertwegh Apr 11, 2024
ff7db04
small change
svandeneertwegh Apr 12, 2024
b9523c4
small change v2
svandeneertwegh Apr 12, 2024
030548c
fix small stuff
svandeneertwegh Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions oscarapi/serializers/product.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ class Meta:


class OptionSerializer(OscarHyperlinkedModelSerializer):
option_group = AttributeOptionGroupSerializer()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think this should be optional, the tests are failing atm!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think it is important to demonstrate the problem in a test, to make sure there are no regressions in the future

code = serializers.SlugField()

class Meta:
Expand Down
Loading