Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize handling of attributes #334

Merged
merged 20 commits into from
Sep 19, 2024
Merged

Optimize handling of attributes #334

merged 20 commits into from
Sep 19, 2024

Commits on Jan 24, 2024

  1. Optimize attribute values (#321)

    * Implemented faster attributes save
    
    * renamed for clarity
    specialunderwear committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    44abf30 View commit details
    Browse the repository at this point in the history
  2. Renamed warning

    specialunderwear committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    13ce8f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b6713b View commit details
    Browse the repository at this point in the history
  4. Make sure to only return attributevalues that are on the actual produ…

    …ct to avoid transferring (#331)
    
    attributesvalues from parent to child.
    specialunderwear authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    20ba73b View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Improve multi db support (#335)

    Use the same database as the passed-in manager
    specialunderwear authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8ea9bf5 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. The image and file fields where nolonger working. (#337)

    * The image and file fields where nolonger working.
    
    This PR restores that functionality.
    
    * nergens voor
    specialunderwear authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f3f041e View commit details
    Browse the repository at this point in the history
  2. fixes tests

    specialunderwear committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a561162 View commit details
    Browse the repository at this point in the history
  3. black

    specialunderwear committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    68c7f4c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    2a9eca5 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Fixes handling of null product image attributes

    When an image product attribute is `null`, the product API would throw the
    following exception:
    
    ```
    ValueError: The 'value_image' attribute has no file associated with it.
    
      […]
    
      File "rest_framework/serializers.py", line 522, in to_representation
        ret[field.field_name] = field.to_representation(attribute)
      File "rest_framework/serializers.py", line 686, in to_representation
        return [
      File "rest_framework/serializers.py", line 687, in <listcomp>
        self.child.to_representation(item) for item in iterable
      File "rest_framework/serializers.py", line 522, in to_representation
        ret[field.field_name] = field.to_representation(attribute)
      File "oscarapi/serializers/fields.py", line 227, in to_representation
        return value.value.url
      File "django/db/models/fields/files.py", line 66, in url
        self._require_file()
      File "django/db/models/fields/files.py", line 41, in _require_file
        raise ValueError(
    ```
    
    This patch fixes this by checking if the image field has a value before trying
    to generate a URL.
    crgwbr committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d4f9994 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Merge pull request #343 from crgwbr/fix_null_image_attrs

    Fixes handling of null product image attributes
    specialunderwear authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c89783e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    410dd8c View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    3b2238a View commit details
    Browse the repository at this point in the history
  2. wops

    viggo-devries committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    236f6d5 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Added Jenkinsfile

    specialunderwear committed May 15, 2024
    Configuration menu
    Copy the full SHA
    94b66d3 View commit details
    Browse the repository at this point in the history
  2. hehe

    specialunderwear committed May 15, 2024
    Configuration menu
    Copy the full SHA
    65ae98f View commit details
    Browse the repository at this point in the history
  3. Merge pull request #346 from django-oscar/category_bulk_api

    Add category bulk admin api
    specialunderwear authored May 15, 2024
    Configuration menu
    Copy the full SHA
    717850b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e665d2d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    0105107 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Improve category upsert and add test (#352)

    * Doe some updating and add test
    
    * refrhes_from_db only path
    
    * Add transaction that rollsback on error
    
    * update versions
    viggo-devries authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cdab4d2 View commit details
    Browse the repository at this point in the history