Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.19] Address caching issue in schema compiler that can lead to OOMs #1329

Open
wants to merge 5 commits into
base: series/0.19
Choose a base branch
from

Commits on Dec 18, 2023

  1. Changes CachedSchemaCompiler to cache the outer schema.

    The CachedSchemaCompiler.Impl class suffered from a pretty dire problem
    of only caching what is passed to the schema visitor. However, schemas
    are often pre-processed before reaching the schema visitors, which,
    combined with a lack of guarantee on Schema equality (in particular for
    Enumeration Schemas in 0.18), and global caches posed a risk of OOMs in
    some cases.
    
    This change makes it so that the initial schema passed to the compiler
    acts as a cache key to a cache that's separate to the one that is
    typically passed to schema visitors.
    Baccata committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e9889ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4cb4a6 View commit details
    Browse the repository at this point in the history
  3. Updated Changelog

    Baccata committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e49b974 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Make 2.12 happy

    Baccata committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    aed5835 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge remote-tracking branch 'origin/series/0.19' into address-cachin…

    …g-issue-in-schema-compiler
    Baccata committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1499eed View commit details
    Browse the repository at this point in the history