Retrieval eval incomplete

[Louis-Mozart]

Comments from the previous PR have been included. The set sorting ensures that we always sample the set in the same order. Hence, make the results reproducible.

[Demirrr]

The set sorting ensures that we always sample the set in the same order. Hence, make the results reproducible.

A set cannot be sorted.

Edit: Could you please explain your reasoning behind sorting a set to make the code reproducable ? @Louis-Mozart

[Demirrr]

@Louis-Mozart is there any update ?

[Louis-Mozart]

Hi @Demirrr. Not really. But I think it is possible because, in Python, sets do not guarantee the order of their elements when converted to lists, this means that each time we convert a set to a list, the order may vary (we can experience this by running the current script many times and add exits like so print(object_properties) exit(0) ). My point is that this inconsistency directly affects the random.sample() function because if the input list’s order changes, the sampled elements may differ even when the same random seed is set. Using sorted(), we ensure that the set converted to a list has a consistent order every time, allowing random.sample() to work with the same ordered input, making the output reproducible across different runs.

[Demirrr]

But I think it is possible because

What does it in this sentence refer to ?

in Python, sets do not guarantee the order of their elements when converted to lists

A set does not have an ordering in any programming language. Therefore, any such convertion does not have any guarantee.

No worries, we will fix this issue

[Demirrr]

@LckyLke or @alkidbaci could you take over this PR from @Louis-Mozart ?

In case any of you would have a question, you can directly contact to @Louis-Mozart.

[Louis-Mozart]

What does it in this sentence refer to?

To the reproducibility of the code.

A set does not have an ordering in any programming language. Therefore, any such convertion does not have any guarantee.

I am not intending to sort a set as this is not possible. But the idea was just to get a sorted list from a set.