discord: Added SelectedValue fields for Channel, Mentionable, User and Role SelectComponents #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmicPredator
changed the title
diamondburned
requested changes
Oct 25, 2024
|
@diamondburned I guess I updated everything and you are gtg |
diamondburned
requested changes
Oct 25, 2024
|
@diamondburned Fixed the requested |
|
@diamondburned Is there anything that needs to be fixed still ?? |
|
Thanks for the bump! I just forgot about this PR for a bit. |
diamondburned
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following fields to ChannelSelectComponent, MentionableSelectComponent and RoleSelectComponent,
SelectedRolesforRoleSelectComponent.SelectedChannelsforChannelSelectComponent.SelectedMentionsforMentionableSelectComponent.SelectedUsersforUserSelectComponent.All the fields will take in the slice of ID's of their kind and populates the SelectComponent beforehand.
Note
SelectedMentionswill take in the slice ofinterface{}and later type-asserted to respective UserID / RoleID.If wanted to change this implementation, please lmk.