Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [ANDROAPP-6101] modify logic for saving completed events #3645

Conversation

xavimolloy
Copy link
Contributor

@xavimolloy xavimolloy commented May 21, 2024

… unit tests for new logic

Description

Please include a summary of the change and include the related jira issue if it exists.

[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-

Solution description

If this PR is a fix include a brief description on how the issue is solved.

Covered unit test cases

Describe the tests that you ran to verify your changes.

Where did you test this issue?

  • Smartphone Emulator
  • Tablet Emulator
  • Smartphone
  • Tablet

Which Android versions did you test this issue?

  • 4.4
  • 5.X - 6.X
  • 7.X
  • 8.X
  • 9.X - 10.X
  • 11.X - 13.X
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@xavimolloy xavimolloy force-pushed the ANDROAPP-6101-User-is-allowed-to-save-errors-when-the-event-is-with-status-complete branch from 95d7712 to 14b666b Compare May 21, 2024 09:41
@xavimolloy xavimolloy marked this pull request as draft May 21, 2024 15:23
@xavimolloy xavimolloy marked this pull request as ready for review May 22, 2024 13:11
@xavimolloy xavimolloy marked this pull request as draft May 22, 2024 13:14
@xavimolloy xavimolloy force-pushed the ANDROAPP-6101-User-is-allowed-to-save-errors-when-the-event-is-with-status-complete branch from 14b666b to 9690067 Compare May 24, 2024 07:46
@xavimolloy xavimolloy marked this pull request as ready for review May 24, 2024 07:48
@xavimolloy xavimolloy requested a review from andresmr May 24, 2024 07:48
@xavimolloy xavimolloy force-pushed the ANDROAPP-6101-User-is-allowed-to-save-errors-when-the-event-is-with-status-complete branch from 1cb72f7 to a71b02e Compare May 24, 2024 10:42
@xavimolloy xavimolloy force-pushed the ANDROAPP-6101-User-is-allowed-to-save-errors-when-the-event-is-with-status-complete branch from a71b02e to 46c5eb0 Compare June 4, 2024 10:57
@xavimolloy xavimolloy force-pushed the ANDROAPP-6101-User-is-allowed-to-save-errors-when-the-event-is-with-status-complete branch from 46c5eb0 to da3b86c Compare June 6, 2024 05:21
Copy link

sonarcloud bot commented Jun 6, 2024

@xavimolloy xavimolloy merged commit 0cd01c9 into release/3.0.1 Jun 6, 2024
4 checks passed
@xavimolloy xavimolloy deleted the ANDROAPP-6101-User-is-allowed-to-save-errors-when-the-event-is-with-status-complete branch June 6, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants