-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-15463] Use dhis2 ui calendarInput component in working list #3712
base: master
Are you sure you want to change the base?
feat: [DHIS2-15463] Use dhis2 ui calendarInput component in working list #3712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alaa-yahia,
I think there are 3 calendar-related Cypress tests in the working list that fail in EventWorkingListsUser.feature. Can you take a look at them?
Support for editable input and dd-mm-yyyy format is needed, therefore this PR is blocked until dhis2/ui#1504 is merged.
6b331e2
to
ba85e8d
Compare
Hey @simonadomnisoru |
ba85e8d
to
7744732
Compare
Hi Alaa, I noticed a few things that I believe need some improvement:
dd-mm-yyyy.format.movLet me know if you need any help. Thank you! |
src/core_modules/capture-core/components/FormFields/DateAndTime/D2Date/D2Date.component.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👏
…s2-ui-calendarinput-component-in-working-list
🚀 Deployed on https://deploy-preview-3712--dhis2-capture.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on 2.42,2.41.2,2.40.5,2.39.7 versions
src/core_modules/capture-core/components/FiltersForTypes/Date/DateFilter.component.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the bug @simonadomnisoru mentioned and I think this is ready. Good work!
src/core_modules/capture-core/components/FiltersForTypes/Date/DateFilter.component.js
Outdated
Show resolved
Hide resolved
09eb852
to
9ef8b02
Compare
Implements DHIS2-15463