Mixer modernisation #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhourahine If we are willing to accept the less tight regression criteria I think this PR is ready for review. My testing indicates that the modern Broyden converges considerably faster in some situations. I'm not happy with the current layout of the source tree, e.g. just dumping all the files in a single folder, but this I deal with in a separate PR. |
aradi
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitutes the existing Simple- and Broyden-mixer by a more recent implementation taken from DFTB+.
For the regression tests to pass I had to soften the tolerances of the regression infrastructure (abs. tol.: 1e-10$\rightarrow$ 1e-08, rel. tol.: 1e-09 $\rightarrow$ 1e-07), which demands for further investigations/discussions. Actually, the current settings were simply far too tight...
To do: