Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(frontend): changes footer copyright text #3588

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BonomoAlessandro
Copy link
Collaborator

@BonomoAlessandro BonomoAlessandro commented Nov 15, 2024

Motivation

Instead of the text © 2024 Developed with ❤️ at DFINITY the text Incubated with ❤️ by DFINITY Foundation © 2024 should be displayed as copyright text in the footer.

Changes

  • changes copyright text

Tests

before:

Desktop:
image

Tablet:
image

Mobile:
image

after:

Desktop:
image

Tablet:
image

Mobile:
image

@BonomoAlessandro BonomoAlessandro marked this pull request as ready for review November 15, 2024 14:05
@BonomoAlessandro BonomoAlessandro requested a review from a team as a code owner November 15, 2024 14:05
@AntonioVentilii
Copy link
Collaborator

I am not sure I really like the mobile version: was it required like this? maybe more space between the icon and the sentence? or even putting "by Dfinity Foundation" in another row together with the year

@BonomoAlessandro
Copy link
Collaborator Author

@AntonioVentilii Sry, you are right. The text needs to be centered. I just fixed it.
fyi: In the next PR the icon will be made a litte bit smaller.

@AntonioVentilii
Copy link
Collaborator

@BonomoAlessandro may you please update the screenshots in the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants