feat(frontend): ConvertAmountSource component #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysKarmazynDFINITY
force-pushed
the
feat(frontend)/convert-amount-source-component
branch
from
fedfbbd
to
ff53508
Compare
|
|
||
| <button | ||
| slot="balance" | ||
| class={`rounded px-2 py-0.5 ${isZeroBalance ? 'bg-error-subtle-alt text-error' : 'bg-zumthor text-blue-ribbon'}`} |
There was a problem hiding this comment.
i think that both zumthor and blue-ribbon can be replaced with the new colors
blue ribbon is text-brand-primary, and the other bg-brand-subtle (please double check)
There was a problem hiding this comment.
good catch, updated!
| <button | ||
| slot="balance" | ||
| class={`rounded px-2 py-0.5 ${isZeroBalance ? 'bg-error-subtle-alt text-error' : 'bg-zumthor text-blue-ribbon'}`} | ||
| on:click|preventDefault={setMax} |
There was a problem hiding this comment.
do we need preventDefault? we do the same elsewhere?
There was a problem hiding this comment.
yep, same as with max button in the send flow - since we don't have a button with type=submit, the whole Send/Convert form will be submitted without preventDefault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Component for handling source token amount input and all related information appearance.
Desktop:
Mobile:
