fix(frontend): do not show token logo in token transaction page #3579
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii
requested review from
peterpeterparker and
DenysKarmazynDFINITY
…n-transaction-page
…n-transaction-page
…n-transaction-page
peterpeterparker
approved these changes
Nov 15, 2024
| @@ -31,7 +32,7 @@ | |||
| <span class="inline-block first-letter:capitalize"><slot /></span> | |||
|
|
|||
| <div slot="icon"> | |||
| {#if nonNullish(token)} | |||
| {#if nonNullish(token) && !hideTokenLogo} | |||
There was a problem hiding this comment.
The token is mandatory now, I guess we can remove nonNullish(token)?
| @@ -18,6 +18,7 @@ | |||
| export let timestamp: number | undefined; | |||
| export let styleClass: string | undefined = undefined; | |||
| export let token: Token; | |||
| export let hideTokenLogo = false; | |||
There was a problem hiding this comment.
Another option is something like as following
export let badge: "token" | "logo" = "logo";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I don't have a better idea: the token logo was being showed in token-specific transaction page, because it is given as input and it is required in components like
BtcTransactionorEthTransaction.However, that same component is needed for the unified transactions (example PR #3570) with the token logo.
So, the only idea I had was to make it so by default the component show the token logo, but not under request (for example in the token-specific transaction page).