Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#312: Added ability to prefer git (ssh) protocol instead of https for cloning repos #724

Merged
merged 39 commits into from
Nov 11, 2024
Merged

#312: Added ability to prefer git (ssh) protocol instead of https for cloning repos #724

merged 39 commits into from
Nov 11, 2024

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Oct 29, 2024 •
edited
Loading

This PR finishes PR #625

Fixes #312

  • Introduced PREFERRED_GIT_PROTOCOL property to allow configuration of preferred Git protocol (SSH or HTTPS).
  • Default behavior remains unchanged if the property is not set, using the provided Git URL as is.
  • Implemented GitUrlSyntax enum to manage and convert between SSH and HTTPS URL formats.
  • Updated GitUrl class for URL parsing and protocol conversion based on the property.
  • Added tests to validate URL conversion and ensure no changes for specific domains like GitHub.
  • When PREFERRED_GIT_PROTOCOL is not defined then URL doesn't change

diiinesh and others added 28 commits September 17, 2024 10:08
@diiinesh
added git url enum GitUrlSyntax.java for ssh and https urls, modified…
1c3750b 
… GitUrl.java to process ssh urls as well, and added tests
@diiinesh
Merge branch 'main' into Enhancement/git_ssh_protocol
73805f7
@diiinesh @hohwille
Update cli/src/main/java/com/devonfw/tools/ide/context/GitUrl.java
69d70fd 
Co-authored-by: Jörg Hohwiller <[email protected]>
@diiinesh @hohwille
Update cli/src/test/java/com/devonfw/tools/ide/context/GitContextTest…
c8a4778 
….java

Co-authored-by: Jörg Hohwiller <[email protected]>
@diiinesh
modifed enum to not take strings as inputs, added VariableDefinitionE…
21ddcf2 
…num.java and seperate IdeVariable, moved test functions to GitUrlSyntax.java
@diiinesh
Merge branch 'main' into Enhancement/git_ssh_protocol
a2dc43d 
# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/context/GitContextImpl.java
@diiinesh
Merge branch 'main' into Enhancement/git_ssh_protocol
c4e38b8
@diiinesh
added PREFERRED_GIT_PROTOCOL property to assert ide properties file
dec7402
@diiinesh
Merge branch 'main' into Enhancement/git_ssh_protocol
89e1b02
@diiinesh
removed property from basic project config file and created new test …
1c5dc97 
…project for git based implementations and its config file
@diiinesh
Merge remote-tracking branch 'origin/Enhancement/git_ssh_protocol' in…
cb2dd52 
…to Enhancement/git_ssh_protocol
@diiinesh
changed test context from basic to git, and added some java docs
d7807ed
@diiinesh
changed test context from basic to git, and added some java docs
98c11d0
@diiinesh
Merge branch 'main' into Enhancement/git_ssh_protocol
b6f18bc
@diiinesh
logging for git action build error
00c2bec
@diiinesh
Merge remote-tracking branch 'origin/Enhancement/git_ssh_protocol' in…
649c9a0 
…to Enhancement/git_ssh_protocol
@diiinesh
logging for git action build error
816bbaf
@diiinesh
logging for git action build error
ca7b2db
@hohwille
Merge branch 'main' into Enhancement/git_ssh_protocol
42b5adc
@diiinesh
revert logging code for searching error in git ci build, added worksp…
8afd40a 
…aces and home dir in test env
@diiinesh
Merge remote-tracking branch 'origin/Enhancement/git_ssh_protocol' in…
1e39f35 
…to Enhancement/git_ssh_protocol
@diiinesh @hohwille
Update cli/src/main/java/com/devonfw/tools/ide/variable/VariableDefin…
d4ad4cf 
…itionEnum.java

Co-authored-by: Jörg Hohwiller <[email protected]>
@diiinesh
added javadoc
5fc97d1
@diiinesh
Merge remote-tracking branch 'origin/Enhancement/git_ssh_protocol' in…
f1039e9 
…to Enhancement/git_ssh_protocol
@diiinesh
added default value
35ef77e
@diiinesh
Merge branch 'main' into Enhancement/git_ssh_protocol
386089a
@alfeilex
Merge remote-tracking branch 'diiinesh/Enhancement/git_ssh_protocol' …
b39addb 
…into devonfw#312-enhance-git-syntax-urls
@alfeilex
remove default value for PREFFERED_GIT_PROTOCOL
fafc51e
@coveralls
Copy link
Collaborator

coveralls commented Oct 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11783308535

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 67.195%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/context/GitUrl.java 3 64.29%
com/devonfw/tools/ide/context/GitContextImpl.java 20 51.72%
Totals Coverage Status
Change from base Build 11783304870: 0.06%
Covered Lines: 6376
Relevant Lines: 9145
💛 - Coveralls

@alfeilex alfeilex mentioned this pull request Oct 29, 2024
Closed
@alfeilex alfeilex self-assigned this Oct 29, 2024
@alfeilex alfeilex marked this pull request as ready for review October 29, 2024 15:51
hohwille
hohwille approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for taking over this PR and completing it. All seems functionally correct and complete now. 👍
I left some comments for final improvement. Please have a look. We can merge if resolved.

cli/src/main/java/com/devonfw/tools/ide/context/GitUrlSyntax.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitUrlSyntax.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContextImpl.java Outdated Show resolved Hide resolved
@hohwille hohwille self-assigned this Oct 31, 2024
@hohwille hohwille added this to the release:2024.11.001 milestone Oct 31, 2024
hohwille
hohwille approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for the rework. All perfect now 👍
Ready for merge.

@hohwille hohwille mentioned this pull request Nov 11, 2024
Open
@hohwille hohwille merged commit 55db46d into devonfw:main Nov 11, 2024
3 checks passed
@alfeilex alfeilex deleted the #312-enhance-git-syntax-urls branch November 11, 2024 19:50
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

@alfeilex alfeilex

Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.11.001
Development

Successfully merging this pull request may close these issues.

Ability to prefer git (ssh) protocol instead of https for cloning repos
4 participants
@alfeilex @coveralls @hohwille @diiinesh