Skip to content

Commit

Permalink
Remove turbodbc build
Browse files Browse the repository at this point in the history
This is removing turbodbc, as we are not able to get the latest version to build (see deephaven#97). This effects our ability to test the latest version of numpy.

See deephaven#71 for related concerns generally about option dependencies and the restrictions they place on server-base.
  • Loading branch information
devinrsmith committed Jun 17, 2024
1 parent 6abafac commit 4efdb04
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 75 deletions.
3 changes: 1 addition & 2 deletions contexts/server-base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ ARG TARGETARCH
ARG UBUNTU_VERSION

# curl is necessary for some kafka integration testing
# unixodbc, odbc-postgresql for postgres / turbodbc integration testing
# unixodbc, odbc-postgresql for postgres integration testing
RUN \
--mount=type=cache,target=/var/cache/apt,sharing=locked,id=apt-${TARGETARCH}-${UBUNTU_VERSION} \
--mount=type=cache,target=/var/lib/apt,sharing=locked,id=apt-${TARGETARCH}-${UBUNTU_VERSION} \
Expand All @@ -87,7 +87,6 @@ ARG REQUIREMENTS_TYPE
RUN \
--mount=type=bind,source=requirements.txt,target=requirements.txt \
--mount=type=bind,source=type/${REQUIREMENTS_TYPE}/requirements.txt,target=requirements-2.txt \
--mount=type=bind,from=turbodbc-wheel,source=/wheels,target=/wheels \
--mount=type=cache,target=/root/.cache/pip,sharing=locked \
set -eux; \
mkdir -p /opt/deephaven; \
Expand Down
4 changes: 0 additions & 4 deletions contexts/server-base/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,5 @@ jedi==0.18.2
adbc-driver-manager
adbc-driver-postgresql

# optional turbodbc feature
# We are adding the arrow/numpy extra requirements to make sure pip installs compatible versions
turbodbc[arrow,numpy]==4.8.0

# optional connectorx feature for x86_64 arch only, no Linux/arm64 wheel yet
connectorx; platform.machine == 'x86_64'
39 changes: 0 additions & 39 deletions contexts/turbodbc-wheel/Dockerfile

This file was deleted.

14 changes: 0 additions & 14 deletions contexts/turbodbc-wheel/requirements.txt

This file was deleted.

16 changes: 0 additions & 16 deletions server-base.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,6 @@ target "server-base-tensorflow" {

target "server-base-context" {
context = "contexts/server-base/"
contexts = {
turbodbc-wheel = "target:turbodbc-wheel"
}
args = {
OPENJDK_VERSION = OPENJDK_VERSION
PYTHON_VERSION = PYTHON_VERSION
Expand All @@ -162,16 +159,3 @@ target "server-base-context" {
}

# -------------------------------------

target "turbodbc-wheel" {
context = "contexts/turbodbc-wheel/"
args = {
PYTHON_VERSION = PYTHON_VERSION
}
platforms = [
MULTI_ARCH || RELEASE ? "linux/amd64" : "",
MULTI_ARCH || RELEASE ? "linux/arm64" : "",
]
}

# -------------------------------------

0 comments on commit 4efdb04

Please sign in to comment.