-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New branch #223
New branch #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description mentions only heap sort but the PR contains code for Kadane's algorithm as well.
Did you intend to make a single PR for two changes or is it by accident?
Yes, it was a mistake. I created heapsort and then I checked and saw that Kadane's Algo was not implemented in C. I intended on creating a separate branch but by mistake I committed them to same branch which got attached to the same PR. |
@swairik it's better if you can create different PRs per algo, would help in reviewing them separately! |
@swairik also I'd recommend you to give good names to pull requests, instead of something like "New branch" |
@codelixir can I then just close this pull request and create a new one following all the guidelines? |
Yes, that would be great, @swairik! Please open a new PR with just heap sort (I think Kadane has been accepted already), thanks. |
I have opened PR #232 implementing heap sort in C. |
This PR implements the code for heap sort in c referred in issue #193
I have read the contributing guidelines in CONTRIBUTING.md and have ensured the following:
This PR creates/modifies the README for
I have read the contributing guidelines in CONTRIBUTING.md and have ensured the following: