Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palindrome using iterators #196

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Palindrome using iterators #196

merged 2 commits into from
Oct 7, 2021

Conversation

rcchcz
Copy link
Contributor

@rcchcz rcchcz commented Oct 6, 2021

This PR implements the code for palindrome checker in C++. This version uses iterators and has a different strategy.

I have read the contributing guidelines in CONTRIBUTING.md and have ensured the following:

  • My code is placed in the required directory as outlined in CONTRIBUTING.md
  • My code file is named according to CONTRIBUTING.md
  • Variables, classes, functions etc. follow camel case as outlined in CONTRIBUTING.md
  • My code hasn't been implemented or claimed by someone else and I have checked the present issues and PRs for the same
  • My code is well commented
  • If my code is the first implementation of , I have added the link to this directory in README.md
  • I have not copied my code from anywhere

@codelixir
Copy link
Collaborator

codelixir commented Oct 7, 2021

Hey, @rcchcz! The code looks good, just one tiny change - please change the name of the file to something like palindrome_WithIterators.cpp (following @deutranium's comment on #191).

Also, according to this repo's CONTRIBUTING.md, you are supposed to comment on the corresponding issue (#161 in this case) before making a PR.

It's okay, I'll merge it this time once you make the change, but please keep this in mind in the future : )

@codelixir codelixir added author response awaited The author has been notified of the changes but haven't responded hacktoberfest-accepted Accepted for Hacktoberfest labels Oct 7, 2021
@rcchcz
Copy link
Contributor Author

rcchcz commented Oct 7, 2021

Oh, my mistake, sorry! I'll fix it now. Thanks!

@deutranium
Copy link
Owner

Looks great, thanks for contributing!

@deutranium deutranium merged commit 8854581 into deutranium:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author response awaited The author has been notified of the changes but haven't responded hacktoberfest-accepted Accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants