refactor: add types #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- This will add types. The behaviour has changed minimally. The conditions don't check for `key in data` but simply `data.key`. I think considering the differences, it's perfectly for fine for this library. How to test ----------- 1. `npm run build` 2. Have a look in `dist/` close derhuerst#6
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
roschaefer
commented
Sep 13, 2024
| @@ -0,0 +1,86 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
We can of course gitignore dist/ folder. I just left it there to be able to install this package from Github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This will add types.
The behaviour has changed minimally. The conditions don't check for
key in databut simplydata.key. I think considering the differences, it's perfectly for fine for this library.How to test
npm run builddist/close #6