Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caches/in-memory): allow explicit in-memory caches #26807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hsjobeki
Copy link

@hsjobeki hsjobeki commented Nov 10, 2024

This fixes the verbose warnings of: #26747

Some users (such as me) don't have access to a writeable file system.
In those cases it would be nice to have a global flag to run deno with in-memory caches only.

The code for falling back to in-memory caches is already there but no way to use it without beeing spammed with concerning error messages.

I could need some help here because i didn't figure out how to properly register the cli flag.

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2024

CLA assistant check
All committers have signed the CLA.

@dsherret
Copy link
Member

What about just not logging when the raw error kind is a readonly file system? That would mean people wouldn't have to discover this flag to supress the warnings.

By the way, I'm not sure about a CLI flag for this. Maybe it should be an env var so all sub commands share the behaviour.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed internally and what would be preferable for this one is to first land a PR with this not warning for readonly file systems. After that's landed and if there's still a need, then have this behaviour triggered by an environment variable.

@dsherret dsherret removed this from the 2.1.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants