fix: enhance hints for bare Node.js built-in modules #26669
+175
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if it makes sense to silence these warnings when the explicit --unstable-bare-node-builtins flag is provided. Maybe a bit of nudging to get things cleaned up is okay. ➜ deno run --unstable-bare-node-builtins -A ../packages/create-solid/src/index.ts
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/commands/dist/handlers/new.mjs:1:324. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "path" as "node:path" at file:///Users/admin/repos/solid-cli/packages/commands/dist/handlers/new.mjs:1:372. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs" as "node:fs" at file:///Users/admin/repos/solid-cli/packages/commands/dist/handlers/new.mjs:1:475. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:1:256. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "os" as "node:os" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:1:306. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "path" as "node:path" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:1:375. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "util" as "node:util" at file:///Users/admin/repos/solid-cli/packages/utils/dist/index.mjs:5:158. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/utils/dist/fs/index.mjs:1:26. If you want to use a built-in Node module, add a "node:" prefix.
Warning Resolving "fs/promises" as "node:fs/promises" at file:///Users/admin/repos/solid-cli/packages/utils/dist/updates/index.mjs:1:37. If you want to use a built-in Node module, add a "node:" prefix. |
bartlomieju
commented
Nov 1, 2024
Comment on lines
+760
to
+761
| Some(format!("If you want to use a built-in Node module, add a \"node:\" prefix (ex. \"node:{specifier}\"), or use | ||
| --unstable-bare-node-builtins flag, or specify `bare-node-builtins` in the `unstable` option in the config file.")) |
There was a problem hiding this comment.
This should actually be reverted, because it's only shown when the flag is present
This reverts commit 5eac6f4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hint was not helpful in all situations as it didn't list the
--unstable-bare-node-builtinsflag or thebare-node-builtinsoption in the
unstableconfig.