Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return error of type 'mssql.Error' directly, because the Number in 'm… #578

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

return error of type 'mssql.Error' directly, because the Number in 'm… #578

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7857e56
return error of type 'mssql.Error' directly, because the Number in 'm…
sdghchj May 7, 2020
dccedbb
use %w to wrap error
sdghchj Nov 4, 2020
efff2aa
Update tds.go
sdghchj Nov 4, 2020
e4e9fd8
Merge branch 'master' into master
sdghchj Feb 23, 2021
a187669
Update tds.go
sdghchj Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,10 +1011,10 @@ initiate_connection:
success = true
sess.loginAck = token
case error:
return nil, fmt.Errorf("Login error: %s", token.Error())
return nil, fmt.Errorf("Login error: %w", token.Error())
case doneStruct:
if token.isError() {
return nil, fmt.Errorf("Login error: %s", token.getError())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could potentially use wrapping here :
return nil, fmt.Errorf("Login error: %w", token.getError())
that would keep the same current format (add the error string), but also provide the full underlying error when using errors.Is/As(...)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

return nil, fmt.Errorf("Login error: %w", token.getError())
}
goto loginEnd
}
Expand Down