add "realtime is disabled" dialog #3405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbenitez
added
the
enhancement
|
To test the changes in this pull request, install this apk: |
r10s
reviewed
Oct 31, 2024
Co-authored-by: bjoern <[email protected]>
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add
window.webxdc.isRealtimeSupported()so apps that don't require the feature to work can avoid the dialog pop up and just keep working without real-time, to mitigate annoyances when apps work without realtime and use it only to add extra features opportunisticallywindow.webxdc.isRealtimeSupported()makes sense in general as some webxdc implementations besides allowing to disable it, might just not support realtime channels feature, as it is more work to implement than the simple basic API, giving the client a way to communicate that the feature is missing without silently doing nothing, so apps can realize the lack of support and adapt or show a warning if they can't work without realtimeI guess this requires the Webxdc spec to be updated as well in some our repos