Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration][omevv_baseline_profile] - Create, Modify and Delete #767

Open
wants to merge 4 commits into
base: collections
Choose a base branch
from

Conversation

rajshekarp87
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@rajshekarp87 rajshekarp87 self-assigned this Nov 14, 2024
@rajshekarp87 rajshekarp87 added the validation/in-progress Validation is in progress label Nov 14, 2024
@rajshekarp87 rajshekarp87 added this to the v9.9.0 milestone Nov 14, 2024
name: OMAM_Baseline_Profile
repository_profile: OMAM_Firm_Repo
cluster:
- Raj-Cluster-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't hardcode cluster name, fetch is dynamically and then pass as required.

<<: *bp_multiple_cluster
register: normal_result_baseline

- name: Verify task status - Create a baseline profile with multiple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetch the baseline profile using GET and then check if there's no diff

state: present
name: OMAM_Baseline_Profile
repository_profile: OMAM_Firm_Repo
cluster: Raj-Cluster-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hardcode cluster

@rajshekarp87 rajshekarp87 force-pushed the integration/omevv_baseline_profile branch from f512504 to 4c0788c Compare November 15, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/in-progress Validation is in progress
Projects
Development

Successfully merging this pull request may close these issues.

3 participants