test(medusa): handlers and setup #51
Conversation
| "platformConfig": { | ||
| "target": "test/invariants/FuzzTest.t.sol", |
There was a problem hiding this comment.
Observation: there's no path branching with regards to fuzz or symbolic within test/invariants.
There was a problem hiding this comment.
symbolic exec is a bit too optimistic timing-wise, we can reorg if we do get there':)
| // Calculate request ID using same logic as Oracle | ||
| bytes32 requestId = keccak256(abi.encode(requestData)); |
There was a problem hiding this comment.
A getId() util would come in handy.
There was a problem hiding this comment.
prophet-core/solidity/libraries/ValidatorLib.sol is at hand.
| IOracle.Response memory response = _ghost_responseData[dispute.responseId]; | ||
| oracle.updateDisputeStatus(_ghost_requestData[requestId], response, dispute, status); |
There was a problem hiding this comment.
Can the call to Oracle::updateDisputeStatus ever bypass the error Oracle_NotDisputeOrResolutionModule, as a part of handleUpdateDisputeStatus()?
| if (_ghost_activeResponses[requestId].length == 0) return (bytes32(0)); | ||
| bytes32 responseId = _ghost_activeResponses[requestId][0]; |
There was a problem hiding this comment.
Shouldn't _getRandomActiveResponse() be used in these situations (seen in handleDisputeResponseOracle() and handleFinalize()) so to fuzz _ghost_activeResponses?
Need review esp for the bond escalation handlers (nbd if faulty, but maybe annoying to debug in the long run).
Sanity check of the setup passes.
+ Might still add some extra-constraints in some handlers