feat: handle requests with no responses after deadline #91
+170
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
reviewed
Nov 18, 2024
| this.logger.info(`Finalizing request ${request.id} with no response`); | ||
|
|
||
| const response: Response["prophetData"] = { | ||
| requestId: "0x0000000000000000000000000000000000000000" as RequestId, // Can be any request ID |
There was a problem hiding this comment.
Suggested change
| requestId: "0x0000000000000000000000000000000000000000" as RequestId, // Can be any request ID | |
| requestId: "0x0000000000000000000000000000000000000000" as RequestId, // Must be 0x0 address |
| return; | ||
| } else { | ||
| // TODO: check for responseModuleData.deadline, if no answer has been accepted after the deadline | ||
| // notify and (TBD) finalize with no response | ||
| // Check if the response deadline has passed with no accepted responses |
There was a problem hiding this comment.
I think we might have an edge case where there are no finalizable responses (yet), there are still some open disputes and one of them could end up with Lost status, thus, causing the disputed response to be the accepted one.
We should check for active disputes, prior finalizing with no request. Something like this probably?
Suggested change
| // Check if the response deadline has passed with no accepted responses | |
| const activeDisputes = this.getActiveDisputes(); | |
| if (activeDisputes.length === 0) return; | |
| // Check if the response deadline has passed with no accepted responses |
| @@ -972,95 +962,5 @@ describe("EboProcessor", () => { | |||
| expect(createRequestSpy).toHaveBeenCalledTimes(1); | |||
| expect(createRequestSpy).toHaveBeenCalledWith(currentEpoch.number, "eip155:42161"); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Just to confirm that I'm not missing anything: these are the duplicated tests, right?
0xnigir1
reviewed
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-236
Description