feat: solve protocol provider todos #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-235
Description
there are two other TODOs left in PP:
"TODO: waiting for ChainId to be merged for _chains parameter"
^ not sure if this one is still relevant?
"TODO: add default caching strategy for RPC client"
^both the client itself and getBlockNumber have a default cache value--do you think it's necessary to have this as an env variable for either/both of these? currently it defaults to a value of 4000ms, not so sure we need to play with this value (https://viem.sh/docs/actions/public/getBlockNumber#cachetime-optional)