Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Write agent app README #75

Merged
merged 5 commits into from
Oct 28, 2024
Merged

chore: Write agent app README #75

merged 5 commits into from
Oct 28, 2024

Conversation

jahabeebs
Copy link
Collaborator

🤖 Linear

Closes GRT-221

Description

  • Adds a README for the agent monorepo

Questions

  • Too soon to add instructions for setting up the e2e tests or should I add the method that we set them up?
  • What more context do you think I should I give for this app that isn't covered in the base repo README?

@jahabeebs jahabeebs requested a review from 0xyaco October 26, 2024 00:23
@jahabeebs jahabeebs self-assigned this Oct 26, 2024
Copy link

linear bot commented Oct 26, 2024

Copy link
Collaborator

@0xyaco 0xyaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some small comments and it's ⏩

3. **Configuration File**:

- The agent also requires a YAML configuration file. The path to this file must be specified in the `.env` file via `EBO_AGENT_CONFIG_FILE_PATH`.
- To set up the configuration, copy `config.example.yml` to `config.yml`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should add explanatory comments inside the config.example.yml file for each of its properties or to add some kind of doc here. I feel like adding comments inside the yml file might be easier to update as they'd be super co-located.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments in config.example.yml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it

Comment on lines 20 to 21
- Create a `.env` file in the root of the `agent` package. Refer to `.env.example` for the required environment variables.
- Populate the file with your environment-specific settings:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a .env file is optional, users could (and probably should but it's up to them) use env vars directly while running the agent. Let's rephrase this one just to show that's not a must to use a .env file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned the option to use the env vars directly

@jahabeebs jahabeebs requested a review from 0xyaco October 28, 2024 15:46
Copy link
Collaborator

@0xyaco 0xyaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Noted some new stuff to have this super neat 💯 after that it's good to go!

Comment on lines 24 to 25
blockByTime: /sf.blockmeta.v2.BlockByTime # Endpoint for block by time service
block: /sf.blockmeta.v2.Block # Endpoint for block service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
blockByTime: /sf.blockmeta.v2.BlockByTime # Endpoint for block by time service
block: /sf.blockmeta.v2.Block # Endpoint for block service
blockByTime: /sf.blockmeta.v2.BlockByTime # Substream's endpoint for "block by time" service
block: /sf.blockmeta.v2.Block # Substream's endpoint for "block" service

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added ✅

| Variable | Description | Required |
| ------------------------------- | ----------------------------------------- | -------- |
| `PROTOCOL_PROVIDER_PRIVATE_KEY` | Private key for the Protocol Provider | Yes |
| `BLOCK_NUMBER_BLOCKMETA_TOKEN` | BlockmetaBlockNumberService bearer token | Yes |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I'm thinking, it'd be nice to add a link or something like that so potential contributors have at least some idea on how to get this token (was something that we struggled with)

Here are two of the main resources that we've used:

Mind adding some footnotes for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added ✅

3. **Configuration File**:

- The agent also requires a YAML configuration file. The path to this file must be specified in the `.env` file via `EBO_AGENT_CONFIG_FILE_PATH`.
- To set up the configuration, copy `config.example.yml` to `config.yml`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it

@jahabeebs jahabeebs requested a review from 0xyaco October 28, 2024 20:22
Copy link
Collaborator

@0xnigir1 0xnigir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go go, just to make the README superpowered, you could use _ [test/e2e/scenarios] (./path_to_file) _ syntax when referencing files or folders

@jahabeebs
Copy link
Collaborator Author

go go, just to make the README superpowered, you could use _ [test/e2e/scenarios] (./path_to_file) _ syntax when referencing files or folders

will do this in my next README pr today 👍🏻

@jahabeebs jahabeebs merged commit 099438a into dev Oct 28, 2024
5 checks passed
@jahabeebs jahabeebs deleted the feat/grt-221-agent-readme branch October 28, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants