chore: base EboActor implementation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xyaco
force-pushed
the
feat/base-ebo-actor
branch
from
abbb140
to
d0171b2
Compare
0xnigir1
previously approved these changes
Aug 1, 2024
| @@ -2,7 +2,7 @@ | |||
| "name": "@ebo-agent/blocknumber", | |||
| "version": "1.0.0", | |||
| "description": "", | |||
| "main": "index.ts", | |||
| "main": "./dist/index.js", | |||
There was a problem hiding this comment.
curiosity and to learn, when we have to point this to dist or why isnt here src/index.js?
There was a problem hiding this comment.
That's an interesting question. Seems like it works both ways and tbh I used what we had already used in the shared package. Do you know if there's any tradeoff between dist and src? Like not having to build dependent packages or something like that?
There was a problem hiding this comment.
tbh i don't know, would have to research more to give a more accurate answer
maybe @0xkenj1 has some insight
There was a problem hiding this comment.
when some other package is using this one the main key of the package.json indicates the entrypoint :)
0xkenj1
previously approved these changes
Aug 1, 2024
0xyaco
dismissed stale reviews from 0xkenj1 and 0xnigir1
The base branch was changed.
0xnigir1
approved these changes
Aug 2, 2024
0xkenj1
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-80
Description
Implements base class for
EboActor