Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ruff updates for DHE support #2280

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

mattrunyon
Copy link
Collaborator

Support for DH-17923 and also fixes some other edge cases with Ruff.

  • Adds a hook for configuring Ruff and keeping it in sync w/ redux settings.
  • Fixes a bug where if Ruff was enabled, but there was no user session then quick fixes were shown but linting underlines were not. Changed so Python is always linted if opened since it doesn't require a session to lint.
  • Allow passing a default config to the Ruff config editor since DHE can set a custom config as the default via server props
  • Added readOnly mode to the Ruff config editor
  • Moved some formatting logic into MonacoUtils since DHE implements its own notebook panel. Eventually we should just consume the DHC NotebookPanel in DHE with extensions for PQs and other DHE options

@mattrunyon mattrunyon requested a review from a team November 6, 2024 00:07
@mattrunyon mattrunyon self-assigned this Nov 6, 2024
@mattrunyon mattrunyon requested review from vbabich and removed request for a team November 6, 2024 00:08
vbabich
vbabich previously approved these changes Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 19.14894% with 38 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (ee0af9c) to head (3f99af5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/console/src/monaco/RuffSettingsModal.tsx 0.00% 16 Missing ⚠️
packages/console/src/monaco/MonacoUtils.ts 0.00% 12 Missing ⚠️
packages/console/src/monaco/MonacoProviders.tsx 16.66% 5 Missing ⚠️
...ashboard-core-plugins/src/panels/NotebookPanel.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
- Coverage   46.62%   46.60%   -0.03%     
==========================================
  Files         702      703       +1     
  Lines       38937    38954      +17     
  Branches     9717     9847     +130     
==========================================
  Hits        18153    18153              
+ Misses      20773    20747      -26     
- Partials       11       54      +43     
Flag Coverage Δ
unit 46.60% <19.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit a35625e into deephaven:main Nov 12, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants