-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdown & overflow-menu): possibility to overwrite the icons #667
Draft
mfranzke
wants to merge
11
commits into
main
Choose a base branch
from
666-feat-provide-possibility-to-overwrite-the-standard-icons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a83aa8a
refactor: provide possibility to overwrite standard icon for this com…
mfranzke 1ce0e5b
chore: simplification
mfranzke a3efe7a
chore: restructuring
mfranzke cc030b7
chore: formatting
mfranzke 05574cf
refactor: provide possibility to overwrite standard icon for this com…
mfranzke a38e188
Update dropdown~individual-icon.md
mfranzke 5b6acaf
Merge branch 'main' into 666-feat-provide-possibility-to-overwrite-th…
mfranzke dc7bf18
Merge branch 'main' into 666-feat-provide-possibility-to-overwrite-th…
mfranzke 65d15c7
Merge branch 'main' into 666-feat-provide-possibility-to-overwrite-th…
annsch bcc1e6c
Merge branch 'main' into 666-feat-provide-possibility-to-overwrite-th…
mfranzke ddf9438
Merge branch 'main' into 666-feat-provide-possibility-to-overwrite-th…
mfranzke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{{> components-overflow-menu patternName="cmp-dropdown" entry01="Profileinstellungen" entry02="Logout" }} | ||
{{> components-overflow-menu patternName="cmp-dropdown" entry01="Profileinstellungen" entry02="Logout" icon=icon }} |
3 changes: 3 additions & 0 deletions
3
source/_patterns/02-components/dropdown/dropdown~individual-icon.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"icon": "add" | ||
} |
9 changes: 9 additions & 0 deletions
9
source/_patterns/02-components/dropdown/dropdown~individual-icon.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
title: Dropddown - Individual icon | ||
state: inreview | ||
order: 3 | ||
--- | ||
|
||
## Individual icon | ||
|
||
By defining an `[data-icon]` on the included `summary` HTML tag, you could overwrite the included standard icon for the button to open the overflow menu. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
source/_patterns/02-components/overflow-menu/overflow-menu~individual-icon.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
"linkEntries": true, | ||
"id": "menu05", | ||
"icon": "add" | ||
} |
9 changes: 9 additions & 0 deletions
9
source/_patterns/02-components/overflow-menu/overflow-menu~individual-icon.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
title: Overflow menu - Individual icon | ||
state: inreview | ||
order: 5 | ||
--- | ||
|
||
## Individual icon | ||
|
||
By defining an `[data-icon]` on the included `summary` HTML tag, you could overwrite the included standard icon for the button to open the overflow menu. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ist it also possible to include a solid icon then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question.