Minimize rebuilds on git version change #1316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sardemff7 you added that option, any feedback on this. I never had issues with this (But rofi compiles so quick, I would not have noticed anyway). |
|
Seems like a good move, but you should put the |
nick87720z
force-pushed
the
git-ver-rebuild
branch
from
2288ad0
to
16d7cb5
Compare
It's headache when even doing commit leads to almost full rebuild due to changed current git version without real content change.
nick87720z
force-pushed
the
git-ver-rebuild
branch
from
16d7cb5
to
0614b9f
Compare
Codecov Report
@@ Coverage Diff @@
## next #1316 +/- ##
==========================================
+ Coverage 32.98% 33.04% +0.06%
==========================================
Files 42 42
Lines 11934 12024 +90
==========================================
+ Hits 3936 3973 +37
- Misses 7998 8051 +53
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now full rebuild happens when current commit changes, which may happen without actual content change - e.g. something is commited or uncommited via
git resetwithout--hardoption. This change makes only necessary files being rebuild - those, using GIT_REVISION.