Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-343: cast to UTC epoch seconds explicitly #179

Merged
merged 3 commits into from
Oct 3, 2024
Merged

PLAT-343: cast to UTC epoch seconds explicitly #179

merged 3 commits into from
Oct 3, 2024

Conversation

ethho
Copy link
Contributor

@ethho ethho commented Oct 3, 2024 •
edited
Loading

PLAT-343 and PLAT-358

Implements https://docs.python.org/3/library/datetime.html#datetime.datetime.timestamp in case .timestamp() is called from a server that doesn't use UTC TZ.

@ethho ethho marked this pull request as ready for review October 3, 2024 20:08
@ethho ethho self-assigned this Oct 3, 2024
@ethho ethho added the bug Something isn't working label Oct 3, 2024
corprew
corprew approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@corprew corprew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ethho ethho merged commit 963e321 into master Oct 3, 2024
16 checks passed
@ethho ethho deleted the fix/plat-343-datetime branch October 3, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corprew corprew corprew approved these changes

@yambottle yambottle Awaiting requested review from yambottle

Assignees

@ethho ethho

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethho @corprew