Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: quality metrics #189

Closed
wants to merge 17 commits into from
Closed

refactor: quality metrics #189

wants to merge 17 commits into from

Conversation

MilagrosMarin
Copy link
Collaborator

@MilagrosMarin MilagrosMarin commented May 1, 2024 •
edited
Loading

Update metrics dataframe renaming.

@MilagrosMarin MilagrosMarin changed the base branch from main to datajoint-spikeinterface May 2, 2024 23:37
@MilagrosMarin MilagrosMarin marked this pull request as ready for review May 20, 2024 13:51
tabedzki and others added 10 commits August 12, 2024 14:54
@tabedzki
Provided raw annotation for strings with unsupported escape regex seq…
f59b4ab 
…uences
@tabedzki
Added minimum version to the setup.py for scikit-image
711dd48
@kushalbakshi
Merge pull request datajoint#198 from BrainCOGS/adding-raw-strings-an…
27c56ea 
…d-package-minimum

Fix regex patterns and add minimum version for scikit-image
@ttngu207
Merge branch 'dev_separated_create_probe' into nei_nienborg
7f52f59
@ttngu207
rearrange: explicitly call probe.create_neuropixels_probe_types() t…
46679e6 
…o create entries in ProbeType
@ttngu207
fix(probe): better handling of different Neuropixels probe types
aaec763
@ttngu207
fix: minor bugfix
e8870b9
@ttngu207
fix(spikeglx): minor bugfix
6764f8c
@ttngu207
update: version and changelog
f754392
@kushalbakshi
Merge pull request datajoint#199 from ttngu207/main
71d9a42 
fix(probe): better handling of different Neuropixels probe types and SpikeGLX meta loader
@ttngu207
Copy link
Contributor

@MilagrosMarin is this PR still valid/relevant?
Should we review/merge or close it?

@MilagrosMarin
Copy link
Collaborator Author

@ttngu207 The purpose of this PR was to:

(1) Integrate new quality metrics from the latest SpikeInterface version 0.101+ into the following ephys modules: ephys_acute, ephys_chronic, and ephys_precluster.
(2) Refactor the calculation of quality metrics in the ephys_no_curation module by moving column mappings into a separate rename_dict variable for improved readability.

However, I am closing this PR for the following reasons:
(1) The PR has been open for a while, and recent updates in datajoint_spikeinterface now conflict with the proposed changes.
(2) The ephys modules are scheduled for relocation, making the changes proposed in this PR no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttngu207 ttngu207 Awaiting requested review from ttngu207

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MilagrosMarin @ttngu207 @tabedzki @kushalbakshi