Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funder Facet (Fair vis feature 2) #990

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Funder Facet (Fair vis feature 2) #990

merged 4 commits into from
Aug 2, 2023

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Aug 1, 2023

  • Add processing for funding aggregates
  • Request funders aggregation from ElasticSearch for Dois
  • Add funder facet to graphql WorkType(s)

Purpose

Export a list of funders for a given group of works

Approach

Create a new facet based on the funder information

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads requested a review from bklaing2 August 1, 2023 23:59
Copy link
Member

@bklaing2 bklaing2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@jrhoads jrhoads merged commit bdea5f4 into master Aug 2, 2023
10 checks passed
@jrhoads jrhoads deleted the fair-viz-feature-2 branch August 2, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants