Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributors missing from filter #989

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

bklaing2
Copy link
Member

Purpose

There is a bug when filtering the contributors. non-ORCID identifiers for names were getting picked up when we created the facets, and then filtered out since they were not ORCIDs. This meant that if the top 10 faceted identifiers were mostly or all non-ORCID, then the final result would be a mostly empty or empty array.

closes: datacite/datacite#1891

Approach

Added the following regex filter to the elasticsearch query so that only ORCID iDs are returned in the first place
https?://orcid.org/.*

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2 bklaing2 requested a review from jrhoads July 31, 2023 11:01
@bklaing2 bklaing2 self-assigned this Jul 31, 2023
@bklaing2 bklaing2 merged commit c5257fd into master Jul 31, 2023
10 checks passed
@bklaing2 bklaing2 deleted the contributors-filter-bug branch July 31, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Creators with ORCID iDs do not appear in the Organization page Authors filter
2 participants