Fix contributors missing from filter #989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There is a bug when filtering the contributors. non-ORCID identifiers for names were getting picked up when we created the facets, and then filtered out since they were not ORCIDs. This meant that if the top 10 faceted identifiers were mostly or all non-ORCID, then the final result would be a mostly empty or empty array.
closes: datacite/datacite#1891
Approach
Added the following regex filter to the elasticsearch query so that only ORCID iDs are returned in the first place
https?://orcid.org/.*
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: