Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new check to exclude specific prefixes from generating events #1265

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

richardhallett
Copy link
Contributor

This is to be used in cases where we want to handle event generation at a later point.

Purpose

Allow specific exclusion for certain prefixes

This is to help especially when ingesting larget amounts of new DOIs

Approach

Check env var for prefix trying to index

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

This is to be used in cases where we want to handle event generation at a later point.
@richardhallett richardhallett requested a review from a team October 17, 2024 10:46
@richardhallett richardhallett self-assigned this Oct 17, 2024
@richardhallett richardhallett merged commit 0d5b6e6 into master Oct 17, 2024
19 checks passed
@richardhallett richardhallett deleted the add_data_import_exclusion branch October 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants