Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix should check for DataCiteDoi #1263

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

richardhallett
Copy link
Contributor

Purpose

DataCiteDoi is the instance name not Doi

Approach

Does it properly this time.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@richardhallett richardhallett requested a review from a team October 16, 2024 14:30
@richardhallett richardhallett self-assigned this Oct 16, 2024
@richardhallett richardhallett merged commit 56c9cfb into master Oct 16, 2024
18 checks passed
@richardhallett richardhallett deleted the move_doi_import_sep_queue branch October 16, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants