Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix set_doi - Use Elastcisearch instead of ActiveRecord #1152

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kaysiz
Copy link
Contributor

@kaysiz kaysiz commented Mar 11, 2024

Purpose

Graphql requests are using a lot of Active record instead of Elastic search.

closes: #1155

Approach

Replace the fetch of records from Active record with Elastic search

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kaysiz kaysiz self-assigned this Mar 11, 2024
@kaysiz kaysiz changed the title WIP: replace active record with elastic search in graphql fix set_doi - Use Elastcisearch instead of ActiveRecord Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix set_doi - Use Elastcisearch instead of ActiveRecord
1 participant