Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL person search errors if there is not a query value #1026

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Oct 20, 2023

Purpose

closes: datacite/datacite#1949

Approach

Add a null safe operator the when stripping out the URL scheme from the the query value. The query can, it seems, sometimes be null. The previous implementation was simply passing the null value into the GraphQL query so we will continue with that approach.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy self-assigned this Oct 20, 2023
@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team October 20, 2023 06:47
Copy link
Member

@bklaing2 bklaing2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bklaing2 bklaing2 merged commit 736428e into master Oct 20, 2023
11 checks passed
@bklaing2 bklaing2 deleted the graphql-person-search-errors-nilclass-error branch October 20, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL person search errors if there is not a query value
2 participants