Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattened Person-Worktype facets for Sankey Visualizations #1000

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Aug 23, 2023

  • Formatting
  • Facet processing for multi-level facet with contributors and work-typs
  • Facet processing to flatten multi-level facets
  • Add multi-level and flat facets for person-worktypes
  • Appease Rubocop
  • Add specs for multi-level and flattened facets
  • Appease Rubocop

Purpose

Provide a flattened facet for person-worktypes
To be used in Sankey diagrams for DMPs
Can be used for any collection of works.

closes: datacite/datacite#1913

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Copy link
Member

@digitaldogsbody digitaldogsbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jrhoads jrhoads merged commit cae3f7a into master Aug 24, 2023
21 checks passed
@jrhoads jrhoads deleted the fair-viz-feature-11 branch August 24, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature 11 (Back End) - Sankey Visualization
2 participants