-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard As Code for Reconcile #768
Conversation
src/databricks/labs/remorph/resources/reconcile/dashboards/dashboard.yml
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/failed_table_list.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/recon_details_pivot.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/recon_details_schema.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/success_table_list.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/success_table_list.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/failed_table_list.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/recon_details_pivot.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/recon_details_schema.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/recon_main.sql
Outdated
Show resolved
Hide resolved
src/databricks/labs/remorph/resources/reconcile/dashboards/0_1_recon_main.sql
Outdated
Show resolved
Hide resolved
updated description |
@nfx why is it moved to in progress? it is blocked by lsql missing features. |
b98e1bf
to
9e6d590
Compare
# Conflicts: # pyproject.toml # src/databricks/labs/remorph/deployment/installation.py # src/databricks/labs/remorph/deployment/recon.py # src/databricks/labs/remorph/resources/reconcile/dashboards/Remorph-Reconciliation.lvdash.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
...ks/labs/remorph/resources/reconcile/dashboards/reconciliation_metrics/05_0_summary_table.sql
Outdated
Show resolved
Hide resolved
.../remorph/resources/reconcile/dashboards/reconciliation_metrics/07_0_schema_details_table.sql
Outdated
Show resolved
Hide resolved
...s/remorph/resources/reconcile/dashboards/reconciliation_metrics/11_0_recon_details_pivot.sql
Outdated
Show resolved
Hide resolved
...s/labs/remorph/resources/reconcile/dashboards/reconciliation_metrics/15_1_failed_targets.sql
Outdated
Show resolved
Hide resolved
...bs/remorph/resources/reconcile/dashboards/reconciliation_metrics/15_2_successful_targets.sql
Outdated
Show resolved
Hide resolved
...bs/remorph/resources/reconcile/dashboards/reconciliation_metrics/17_0_mismatched_records.sql
Outdated
Show resolved
Hide resolved
.../remorph/resources/reconcile/dashboards/reconciliation_metrics/17_1_threshold_mismatches.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes #708
The existing dashboard has been broken into 2.
For features unsupported by LSQL, we are using overrides to implement the required widgets.
Conditional formatting depends on databrickslabs/lsql#299
Screenshots:
-- co-authored by @bishwajit-db and @sundarshankar89