Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Improved ApplicationContext to generically parse --dialect and --source-queries flags #1051

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Nov 4, 2024

i've noticed that debug-estimate command was never properly added. And we had few different ways to init query history and dialects. This PR fixes that.

@nfx nfx requested a review from vil1 November 4, 2024 11:43
@nfx nfx added the internal technical pr's not end user facing label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Coverage tests results

445 tests  ±0   411 ✅ ±0   4s ⏱️ ±0s
  6 suites ±0    34 💤 ±0 
  6 files   ±0     0 ❌ ±0 

Results for commit 661b684. ± Comparison against base commit b96aa6a.

♻️ This comment has been updated with latest results.

@nfx nfx mentioned this pull request Nov 4, 2024
@nfx nfx merged commit 2df8105 into main Nov 4, 2024
8 checks passed
@nfx nfx deleted the fix/dialect-factory branch November 4, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal technical pr's not end user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant