Introduce an abstraction for handling stateful traversal of the tree #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
reviewed
Oct 29, 2024
core/src/main/scala/com/databricks/labs/remorph/RemorphContext.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/databricks/labs/remorph/generators/sql/ExpressionGenerator.scala
Outdated
Show resolved
Hide resolved
vil1
force-pushed
the
feat/manage-state
branch
2 times, most recently
from
77c44fd
to
ede2f07
Compare
nfx
requested changes
Oct 30, 2024
core/src/main/scala/com/databricks/labs/remorph/RemorphContext.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/databricks/labs/remorph/RemorphContext.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/databricks/labs/remorph/generators/package.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/databricks/labs/remorph/generators/package.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/databricks/labs/remorph/RemorphContext.scala
Outdated
Show resolved
Hide resolved
…(and still being able to accumulate errors, etc)
vil1
force-pushed
the
feat/manage-state
branch
from
ede2f07
to
26f8ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While still being able to accumulate errors, produce partial results, etc.
The base principle is to build a representation of the computation (parsing, visiting, optimizing, generating, etc) that will eventually get
run. This representation keeps track of a state (of arbitrary type if we wanted to, but we practically stick toRemorphContextfor now) along with the result it is producing.This way, we can interleave any step of the computation with updates to this state, like counting the statements processed thus far (for any definition of what a statement is, including arbitrarily nested subqueries), the branch of the IR tree currently being processed, etc.
Similarly, at any point of the computation, we can inspect the current state, to guide said computation (by customizing error messages with contextual information for example).