Convert Dashboard
objects to dict in LakeviewAPI
create
and update
methods
#824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Convert
Dashboard
objects to dict inLakeviewAPI
create
andupdate
methods. The API expects a JSON serializable object where the Python dataclasses are not. By converting these dataclass instances to dicts the objects become JSON serializable.This issue
_api
attribute misses type hintingLakeviewAPI
methodsHow is this tested?
Did not look into testing this.