Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Dashboard objects to dict in LakeviewAPI create and update methods #824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JCZuurmond
Copy link

What changes are proposed in this pull request?

Convert Dashboard objects to dict in LakeviewAPI create and update methods. The API expects a JSON serializable object where the Python dataclasses are not. By converting these dataclass instances to dicts the objects become JSON serializable.

This issue

  • Went undetected by the linter as the _api attribute misses type hinting
  • Remains for other LakeviewAPI methods
  • Breaks the current ucx version
  • Breaks the current lsql version

How is this tested?

Did not look into testing this.

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 824
  • Commit SHA: d90db450984b10d36338ebeaf4f80ce3633c50c0

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant