Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token cache for oauth #823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eric-wang-1990
Copy link

@eric-wang-1990 eric-wang-1990 commented Nov 15, 2024

What changes are proposed in this pull request?

This PR change the OAuth token cache that when the cached oauth token cannot be refreshed, we still wanna go trigger a new OAuth login flow instead of just throwing an exception.
This help customers who use OAuth U2M, when their cached access token expire they have a way to continue rather than stuck with exception.

How is this tested?

Manual test from dbt-databricks.

ALWAYS ANSWER THIS QUESTION: Answer with "N/A" if tests are not applicable
to your PR (e.g. if the PR only modifies comments). Do not be afraid of
answering "Not tested" if the PR has not been tested. Being clear about what
has been done and not done provides important context to the reviewers.

Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 823
  • Commit SHA: 8d2337276dcf1836c6d3ea849ed32c3690f7a811

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant