Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace Hack, CLASSES Config Option #13

Closed
wants to merge 3 commits into from
Closed

Namespace Hack, CLASSES Config Option #13

wants to merge 3 commits into from

Conversation

wbraswell
Copy link
Contributor

This first commit implements the proposed solution B for the Namespace Hack, Part 2 issue: #7

Included in this commit is the code required to implement the solution, test it in the exact manner shown for the previously-existing t/namespace tests, and document it in the POD file.

There is no code included in this commit that is not directly related to, and required by, the proposed solution B.

@wbraswell wbraswell mentioned this pull request Aug 8, 2014
@daoswald
Copy link
Owner

daoswald commented Aug 8, 2014

Thanks for the pull request. I'll review and hopefully merge in a few days (AFK starting in a few mins)

@wbraswell
Copy link
Contributor Author

This second commit standardizes our use of Inline config options to be lower case, now that Inline supports case insensitive config options. All tests pass.

This second commit does not contain any changes other than standardizing on lower case config options.

@wbraswell
Copy link
Contributor Author

This third commit implements a combination of the proposed solution C and @mohawk2's coderef proposed solution for the Namespace Hack, Part 2 issue: #7

This commit provides an automated solution which builds upon, but does not replace, the first commit implementing the manual solution A. The manual solution may be used for simple codebases, while the automated solution is needed for more complex situations, such as RPerl.

Included in this commit is the code required to implement the solution, test it in the exact manner shown for the previously-existing t/classes tests, and document it in the POD file.

There is no code included in this commit that is not directly related to, and required by, the proposed solution C and coderef combination.

@mohawk2
Copy link
Collaborator

mohawk2 commented Aug 10, 2014

That t/classes/07conflict_avoid.t needs work. If you want to create a temporary file or dir, that's fine, just use File::Temp->newdir which will auto cleanup at END.

@mohawk2
Copy link
Collaborator

mohawk2 commented Aug 10, 2014

Why are you having the code-ref return a list, not just a Perl classname?

@wbraswell
Copy link
Contributor Author

Inline::CPP requires $pkg and $class be 2 separate variables, thus they are returned as such by the coderef solution.

@daoswald
Copy link
Owner

I've merged this into the upstream repo under the wbraswell-classes branch for further review, with the intent of being able to merge with master when ready.

Auto-merge wasn't possible since the pull request created a conflict in version numbering. But the conflict has been resolved and the pull request now exists in this repo under wbraswell-classes.

@daoswald daoswald closed this Aug 11, 2014
@mohawk2
Copy link
Collaborator

mohawk2 commented Aug 11, 2014

I fixed the left-in Data::Dumper line in bb4f95e on that branch.

@daoswald
Copy link
Owner

This pull request has now been adapted and merged into master, and will be released as CPAN v0.57. Thanks!

@wbraswell
Copy link
Contributor Author

Great, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants